forked from HuidaeCho/grass
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake build work #2
Merged
Mahesh1998
merged 79 commits into
Mahesh1998:cmake_build_work
from
HuidaeCho:cmake_build_work
Aug 12, 2024
Merged
Cmake build work #2
Mahesh1998
merged 79 commits into
Mahesh1998:cmake_build_work
from
HuidaeCho:cmake_build_work
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename l to line when using `f.readlines()`. * Remove "l"s from parameters since they aren't used. * Rename "l" to "lx" to assign a lexer object. * Add "# noqa: E741" as renaming parameters won't be applicable in this case. * Rename "l" to "ln" as line number. * Rename "l" to "layer" when looping through the layer list. * Remove E741 for files in the 'locale', `python`, and `scripts` directory. * Rename "ln" to "line_number".
* Add JSON support to r.univar Use parson to add json output format support to the r.univar module. * Apply suggestions from code review --------- Co-authored-by: Nicklas Larsson <[email protected]>
* Add JSON support to v.univar Use parson to add json output format support to the v.univar module. * update percentile format * rename test file
…o#3979) Reduce scope of minreg and maxreg variables in d.labels/main.c Co-authored-by: Shubham Vasudeo Desai <[email protected]>
Reduce scope of 'bg_w' variable in d.legend.vect/draw.c Co-authored-by: Shubham Vasudeo Desai <[email protected]>
…eo#3975) Fix uninitialized variable 'encoding' in parser_interface.c Co-authored-by: Shubham Vasudeo Desai <[email protected]>
* CI(ruff): Fix typo in ruff suggestions * CI(ruff): Upload suggestions even if not all linting errors were fixed * CI(ruff): Try suggesting more changes * CI(ruff): Upload suggestions even if not all linting errors were fixed but do not run when cancelled
…grass.script as gs`) (OSGeo#3981) * style: Unignore unconventional-import-alias (ICN001) ruff rule * style: Use convention `import matplotlib as mpl` * style: Use convention `import numpy as np` * style: Use convention `import grass.script as gs` * test: Remove unused grass.script in test file * style: Add missing alias to `import grass.script as gs` * style: Alias `import grass.script as gs` when already imported at file-level * Remove duplicated grass.script lazy import in wxpython/gui_core/ghelp.py
…ft.c (OSGeo#3973) imagery: Fix uninitialized struct member 'ngbr_rc.next' in mean_shift.c Co-authored-by: Shubham Vasudeo Desai <[email protected]>
Co-authored-by: Shubham Vasudeo Desai <[email protected]>
…SGeo#3974) * Fix uninitialized struct member error in region_growing.c Co-authored-by: Shubham Vasudeo Desai <[email protected]> Co-authored-by: Shubham Vasudeo Desai <[email protected]>
…p, dp_max, dm, and dm_max to 0.0 (OSGeo#3995) Fixed uninitialized variable warning in dmax.c by initializing dp, dp_max, dm, and dm_max to 0.0.
* temporal: Actually call dbif.close() to fix pylint pointless-statement (W0104) * g.extension: Fix pylint pointless-statement (W0104) * temporal: Fix pointless-statement (W0104) in temporal_granularity * temporal: Fix pointless-statement (W0104) in c_libraries_interface.py, _read_vector_history() function * i.atcorr: Remove useless and non-working print statements in create_iwave.py * python(grass.imaging): Use PIL.__version__ call to fix pylint pointless-statement * style: Ignore ruff useless-expression (B018) for a gunittest data file. Equivalent to pylint pointless-statement / W010 * style: Enable ruff useless-expression (B018) (equivalent to pylint pointless-statement / W010)
Using `ruff check --output-format=concise --preview --select UP022 --unsafe-fixes --fix`
…ue (SIM211) (OSGeo#3999) Relates to pylint rule simplifiable-if-expression / R1719
* python(grass.temporal): Fix pylint try-except-raise (W0706) Do not catch exception only to raise it again * gui/wxpython/core/utils: Fix pylint try-except-raise (W0706) * python: Fix pylint try-except-raise (W0706) * style: Enable ruff useless-try-except (TRY302) as fixed
…4065) raster: Fix uninitialized variable issue for c files in raster
Fixed Building grass with Ubuntu System Libraries and cmake
Added parson to r.univar, r3.univar, v.univar
Mahesh1998
merged commit Aug 12, 2024
7da418b
into
Mahesh1998:cmake_build_work
16 of 22 checks passed
@@ -218,7 +217,7 @@ | |||
) | |||
args = parser.parse_args() | |||
|
|||
cfile = args.text if args.text else urlopen(args.url, proxies=None) | |||
cfile = args.text or urlopen(args.url, proxies=None) |
Check warning
Code scanning / Bandit
Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected. Warning
Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To sync with original cmake_build_work from @HuidaeCho repository