Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake build work #2

Merged
merged 79 commits into from
Aug 12, 2024
Merged

Conversation

Mahesh1998
Copy link
Owner

@Mahesh1998 Mahesh1998 commented Aug 12, 2024

To sync with original cmake_build_work from @HuidaeCho repository

mshukuno and others added 30 commits July 2, 2024 16:12
* Rename l to line when using `f.readlines()`.

* Remove "l"s from parameters since they aren't used.

* Rename "l" to "lx" to assign a lexer object.

* Add "# noqa: E741" as renaming parameters won't be applicable in this case.

* Rename "l" to "ln" as line number.

* Rename "l" to "layer" when looping through the layer list.

* Remove E741 for files in the 'locale', `python`, and `scripts` directory.

* Rename "ln" to "line_number".
* Add JSON support to r.univar

Use parson to add json output format support to the r.univar module.

* Apply suggestions from code review

---------

Co-authored-by: Nicklas Larsson <[email protected]>
* Add JSON support to v.univar

Use parson to add json output format support to the v.univar module.

* update percentile format

* rename test file
…o#3979)

Reduce scope of minreg and maxreg variables in d.labels/main.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>
Reduce scope of 'bg_w' variable in d.legend.vect/draw.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>
…eo#3975)

Fix uninitialized variable 'encoding' in parser_interface.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>
* CI(ruff): Fix typo in ruff suggestions

* CI(ruff): Upload suggestions even if not all linting errors were fixed

* CI(ruff): Try suggesting more changes

* CI(ruff): Upload suggestions even if not all linting errors were fixed but do not run when cancelled
…grass.script as gs`) (OSGeo#3981)

* style: Unignore unconventional-import-alias (ICN001) ruff rule

* style: Use convention `import matplotlib as mpl`

* style: Use convention `import numpy as np`

* style: Use convention `import grass.script as gs`

* test: Remove unused grass.script in test file

* style: Add missing alias to `import grass.script as gs`

* style: Alias `import grass.script as gs` when already imported at file-level

* Remove duplicated grass.script lazy import in wxpython/gui_core/ghelp.py
…ft.c (OSGeo#3973)

imagery: Fix uninitialized struct member 'ngbr_rc.next' in mean_shift.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>
…SGeo#3974)

* Fix uninitialized struct member error in region_growing.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>
Co-authored-by: Shubham Vasudeo Desai <[email protected]>
…p, dp_max, dm, and dm_max to 0.0 (OSGeo#3995)

Fixed uninitialized variable warning in dmax.c by initializing dp, dp_max, dm, and dm_max to 0.0.
* temporal: Actually call dbif.close() to fix pylint pointless-statement (W0104)

* g.extension: Fix pylint pointless-statement (W0104)

* temporal: Fix pointless-statement (W0104) in temporal_granularity

* temporal: Fix pointless-statement (W0104) in c_libraries_interface.py, _read_vector_history() function

* i.atcorr: Remove useless and non-working print statements in create_iwave.py

* python(grass.imaging): Use PIL.__version__ call to fix pylint pointless-statement

* style: Ignore ruff useless-expression (B018) for a gunittest data file. Equivalent to pylint pointless-statement / W010

* style: Enable ruff useless-expression (B018) (equivalent to pylint pointless-statement / W010)
Using `ruff check --output-format=concise --preview --select UP022 --unsafe-fixes --fix`
…ue (SIM211) (OSGeo#3999)

Relates to pylint rule simplifiable-if-expression / R1719
* python(grass.temporal): Fix pylint try-except-raise (W0706)

Do not catch exception only to raise it again

* gui/wxpython/core/utils: Fix pylint try-except-raise (W0706)

* python: Fix pylint try-except-raise (W0706)

* style: Enable ruff useless-try-except (TRY302) as fixed
@@ -218,7 +217,7 @@
)
args = parser.parse_args()

cfile = args.text if args.text else urlopen(args.url, proxies=None)
cfile = args.text or urlopen(args.url, proxies=None)

Check warning

Code scanning / Bandit

Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected. Warning

Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants